Short summary could just be: "Add check_data handle() to struct tpm_tis_phy_ops" and leave the reasoning to the long description. On Sun, Apr 05, 2020 at 03:53:47PM +0300, amirmizi6@xxxxxxxxx wrote: > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > In order to compute the crc over the data sent in lower layer > (I2C for instance), tpm_tis_check_data() calls an operation (if available) > to check data integrity. If data integrity cannot be verified, a retry > attempt to save the sent/received data is implemented. It does not. The existing code does not do that. Also it is not clear whether the steps are from existing code or after this commit has been applied. /Jarkko