Hi Geert, On Mon, Apr 06, 2020 at 10:47:37AM +0200, Geert Uytterhoeven wrote: > On Mon, Apr 6, 2020 at 1:24 AM Laurent Pinchart wrote: > > Convert the Renesas R-Car LVDS encoder text binding to YAML. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml > > @@ -0,0 +1,248 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/renesas,lvds.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas R-Car LVDS Encoder > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > + > > +description: | > > + These DT bindings describe the LVDS encoder embedded in the Renesas R-Car > > + Gen2, R-Car Gen3 and RZ/G SoCs. > > RZ/G1 and RZ/G2 (no idea what'll RZ/G3 will bring ;-) Fixed. > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,r8a7743-lvds # for R8A7743 (RZ/G1M) compatible LVDS encoders > > + - renesas,r8a7744-lvds # for R8A7744 (RZ/G1N) compatible LVDS encoders > > + - renesas,r8a774a1-lvds # for R8A774A1 (RZ/G2M) compatible LVDS encoders > > + - renesas,r8a774b1-lvds # for R8A774B1 (RZ/G2N) compatible LVDS encoders > > + - renesas,r8a774c0-lvds # for R8A774C0 (RZ/G2E) compatible LVDS encoders > > + - renesas,r8a7790-lvds # for R8A7790 (R-Car H2) compatible LVDS encoders > > + - renesas,r8a7791-lvds # for R8A7791 (R-Car M2-W) compatible LVDS encoders > > + - renesas,r8a7793-lvds # for R8A7793 (R-Car M2-N) compatible LVDS encoders > > + - renesas,r8a7795-lvds # for R8A7795 (R-Car H3) compatible LVDS encoders > > + - renesas,r8a7796-lvds # for R8A7796 (R-Car M3-W) compatible LVDS encoders > > R8A77960 (I know you don't have support for R8A77961 yet ;-) > > > + - renesas,r8a77965-lvds # for R8A77965 (R-Car M3-N) compatible LVDS encoders > > + - renesas,r8a77970-lvds # for R8A77970 (R-Car V3M) compatible LVDS encoders > > + - renesas,r8a77980-lvds # for R8A77980 (R-Car V3H) compatible LVDS encoders > > + - renesas,r8a77990-lvds # for R8A77990 (R-Car E3) compatible LVDS encoders > > + - renesas,r8a77995-lvds # for R8A77995 (R-Car D3) compatible LVDS encoders > > Wouldn't it be sufficient to just have the SoC name (e.g. "R-Car D3") in > the comments? Good idea. I've thus dropped R8A7796(0) :-) > > +if: > > + properties: > > + compatible: > > + enum: > > + - renesas,r8a774c0-lvds > > + - renesas,r8a77990-lvds > > + - renesas,r8a77995-lvds > > +then: > > + properties: > > + clocks: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - description: Functional clock > > + - description: EXTAL input clock > > + - description: DU_DOTCLKIN0 input clock > > + - description: DU_DOTCLKIN1 input clock > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - const: fck > > + # The LVDS encoder can use the EXTAL or DU_DOTCLKINx clocks. > > + # These clocks are optional. > > + - enum: > > + - extal > > + - dclkin.0 > > + - dclkin.1 > > + - enum: > > + - extal > > + - dclkin.0 > > + - dclkin.1 > > + - enum: > > + - extal > > + - dclkin.0 > > + - dclkin.1 > > Can the duplication of the last 3 entries be avoided? > Perhaps like in > Documentation/devicetree/bindings/serial/renesas,scif.yaml? I'd love to, if you can tell me how to make sure the fck entry is mandatory. The following minItems: 1 maxItems: 4 items: enum: - fck - extal - dclkin.0 - dclkin.1 passes the checks, but would accept clock-names = "extal"; which is not valid. Your Documentation/devicetree/bindings/serial/renesas,scif.yaml bindings suffer from the same problem :-) > > +examples: > > + - | > > + #include <dt-bindings/clock/renesas-cpg-mssr.h> > > + #include <dt-bindings/power/r8a7795-sysc.h> > > + > > + lvds@feb90000 { > > + compatible = "renesas,r8a7795-lvds"; > > + reg = <0 0xfeb90000 0 0x14>; > > Examples are built with #{address,size}-cells = <1>. Are they ? I don't get any failure from make dt_binding_check. > > + lvds0: lvds@feb90000 { > > + compatible = "renesas,r8a77990-lvds"; > > + reg = <0 0xfeb90000 0 0x20>; > > Likewise. > > > + lvds1: lvds@feb90100 { > > + compatible = "renesas,r8a77990-lvds"; > > + reg = <0 0xfeb90100 0 0x20>; > > Likewise. -- Regards, Laurent Pinchart
