Hi Laurent, On Mon, Apr 6, 2020 at 1:40 AM Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: > Convert the Renesas R-Car DWC HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > +properties: > + compatible: > + items: > + - enum: > + - renesas,r8a774a1-hdmi # for R8A774A1 (RZ/G2M) compatible HDMI TX > + - renesas,r8a774b1-hdmi # for R8A774B1 (RZ/G2N) compatible HDMI TX > + - renesas,r8a7795-hdmi # for R8A7795 (R-Car H3) compatible HDMI TX > + - renesas,r8a7796-hdmi # for R8A7796 (R-Car M3-W) compatible HDMI TX R8A77960 (I know you don't support R8A77961 yet ;-) > + - renesas,r8a77965-hdmi # for R8A77965 (R-Car M3-N) compatible HDMI TX Wouldn't it be sufficient to just have the SoC name (e.g. "R-Car M3-N") in the comments? > + - const: renesas,rcar-gen3-hdmi # R-Car Gen3 and RZ/G2 > +examples: > + - | > + #include <dt-bindings/clock/r8a7795-cpg-mssr.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/power/r8a7795-sysc.h> > + > + hdmi@fead0000 { > + compatible = "renesas,r8a7795-hdmi", "renesas,rcar-gen3-hdmi"; > + reg = <0 0xfead0000 0 0x10000>; Examples are built with #{address,size}-cells = <1>. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds