On Fri, 3 Apr 2020 18:54:02 -0500, Dinh Nguyen wrote: > Document the Agilex clock bindings, and add the clock header file. The > clock header is an enumeration of all the different clocks on the Agilex > platform. > > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> > --- > v5: update license to GPL-2.0-only > Add additionalProperties > Add clock input for clkmgr > v4: really fix build error(comment formatting was wrong) > v3: address comments from Stephen Boyd > fix build error(tab removed in line 37) > renamed to intel,agilex.yaml > v2: convert original document to YAML > --- > .../bindings/clock/intel,agilex.yaml | 40 +++++++++++ > include/dt-bindings/clock/agilex-clock.h | 70 +++++++++++++++++++ > 2 files changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/intel,agilex.yaml > create mode 100644 include/dt-bindings/clock/agilex-clock.h > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/intel,agilex.example.dt.yaml: clock-controller@ffd10000: 'clocks', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+' See https://patchwork.ozlabs.org/patch/1266287 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.