... > > > > > +#define ADIS16475_GYRO_CHANNEL(_mod) \ > > > > + ADIS16475_MOD_CHAN(IIO_ANGL_VEL, IIO_MOD_ ## _mod, \ > > > > + ADIS16475_REG_ ## _mod ## _GYRO_L, ADIS16475_SCAN_GYRO_ ## > > > _mod, 32, \ > > > > + 32) > > > > > > It's not obvious that this is macro inside macro. Can you indent better? > > > Ditto for the rest similar ones. > > > > > > > Honestly here I don't see any problems with indentation and it goes in conformity with > > other IMU drivers already in tree. So here, as long as anyone else has a problem with this, I prefer > > to keep it this way... > > I'm not a maintainer, not my call :-) I'm lazy when it comes to things like this. Yes it could be better, but it's still fairly readable so I don't really mind. That's not to say I don't like beautiful things if you don't mind tidying it up? :) Jonathan
