Hi Alex,
On 02/04/2020 19:34, Alex Riesen wrote:
> Signed-off-by: Alexander Riesen <alexander.riesen@xxxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
I guess we could have also added this directly to the helper macros, but
there is indeed already a mixed usage so either way would require fixups
to be consistent.
So this is a good option ;-)
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/adv748x/adv748x-core.c | 24 ++++++++++++------------
> drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 23e02ff27b17..c3fb113cef62 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -623,11 +623,11 @@ static int adv748x_parse_dt(struct adv748x_state *state)
>
> for_each_endpoint_of_node(state->dev->of_node, ep_np) {
> of_graph_parse_endpoint(ep_np, &ep);
> - adv_info(state, "Endpoint %pOF on port %d", ep.local_node,
> + adv_info(state, "Endpoint %pOF on port %d\n", ep.local_node,
> ep.port);
>
> if (ep.port >= ADV748X_PORT_MAX) {
> - adv_err(state, "Invalid endpoint %pOF on port %d",
> + adv_err(state, "Invalid endpoint %pOF on port %d\n",
> ep.local_node, ep.port);
>
> continue;
> @@ -635,7 +635,7 @@ static int adv748x_parse_dt(struct adv748x_state *state)
>
> if (state->endpoints[ep.port]) {
> adv_err(state,
> - "Multiple port endpoints are not supported");
> + "Multiple port endpoints are not supported\n");
> continue;
> }
>
> @@ -702,62 +702,62 @@ static int adv748x_probe(struct i2c_client *client)
> /* Discover and process ports declared by the Device tree endpoints */
> ret = adv748x_parse_dt(state);
> if (ret) {
> - adv_err(state, "Failed to parse device tree");
> + adv_err(state, "Failed to parse device tree\n");
> goto err_free_mutex;
> }
>
> /* Configure IO Regmap region */
> ret = adv748x_configure_regmap(state, ADV748X_PAGE_IO);
> if (ret) {
> - adv_err(state, "Error configuring IO regmap region");
> + adv_err(state, "Error configuring IO regmap region\n");
> goto err_cleanup_dt;
> }
>
> ret = adv748x_identify_chip(state);
> if (ret) {
> - adv_err(state, "Failed to identify chip");
> + adv_err(state, "Failed to identify chip\n");
> goto err_cleanup_dt;
> }
>
> /* Configure remaining pages as I2C clients with regmap access */
> ret = adv748x_initialise_clients(state);
> if (ret) {
> - adv_err(state, "Failed to setup client regmap pages");
> + adv_err(state, "Failed to setup client regmap pages\n");
> goto err_cleanup_clients;
> }
>
> /* SW reset ADV748X to its default values */
> ret = adv748x_reset(state);
> if (ret) {
> - adv_err(state, "Failed to reset hardware");
> + adv_err(state, "Failed to reset hardware\n");
> goto err_cleanup_clients;
> }
>
> /* Initialise HDMI */
> ret = adv748x_hdmi_init(&state->hdmi);
> if (ret) {
> - adv_err(state, "Failed to probe HDMI");
> + adv_err(state, "Failed to probe HDMI\n");
> goto err_cleanup_clients;
> }
>
> /* Initialise AFE */
> ret = adv748x_afe_init(&state->afe);
> if (ret) {
> - adv_err(state, "Failed to probe AFE");
> + adv_err(state, "Failed to probe AFE\n");
> goto err_cleanup_hdmi;
> }
>
> /* Initialise TXA */
> ret = adv748x_csi2_init(state, &state->txa);
> if (ret) {
> - adv_err(state, "Failed to probe TXA");
> + adv_err(state, "Failed to probe TXA\n");
> goto err_cleanup_afe;
> }
>
> /* Initialise TXB */
> ret = adv748x_csi2_init(state, &state->txb);
> if (ret) {
> - adv_err(state, "Failed to probe TXB");
> + adv_err(state, "Failed to probe TXB\n");
> goto err_cleanup_txa;
> }
>
> diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c b/drivers/media/i2c/adv748x/adv748x-csi2.c
> index 2091cda50935..c43ce5d78723 100644
> --- a/drivers/media/i2c/adv748x/adv748x-csi2.c
> +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c
> @@ -72,7 +72,7 @@ static int adv748x_csi2_registered(struct v4l2_subdev *sd)
> struct adv748x_state *state = tx->state;
> int ret;
>
> - adv_dbg(state, "Registered %s (%s)", is_txa(tx) ? "TXA":"TXB",
> + adv_dbg(state, "Registered %s (%s)\n", is_txa(tx) ? "TXA":"TXB",
> sd->name);
>
> /*
>
--
Regards
--
Kieran
