Hi Prabhakar-san, Thank you for your patch! > From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM <snip> > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > new file mode 100644 > index 000000000000..07cd5a7325d0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0 I'm sorry I should have mentioned in the previous review. This is better like the following. # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) https://patchwork.kernel.org/patch/11459267/#23246825 <snip> > +examples: > + - | > + #include <dt-bindings/clock/r8a774c0-cpg-mssr.h> > + #include <dt-bindings/power/r8a774c0-sysc.h> > + > + pcie0_ep: pcie-ep@fe000000 { > + compatible = "renesas,r8a774c0-pcie-ep", > + "renesas,rcar-gen3-pcie-ep"; > + reg = <0 0xfe000000 0 0x80000>, > + <0x0 0xfe100000 0 0x100000>, > + <0x0 0xfe200000 0 0x200000>, > + <0x0 0x30000000 0 0x8000000>, > + <0x0 0x38000000 0 0x8000000>; Examples are built with #{address,size}-cells = <1>, so reg = <0xfe000000 0x80000>, <0xfe100000 0x100000>, <0xfe200000 0x200000>, <0x30000000 0x8000000>, <0x38000000 0x8000000>; https://patchwork.kernel.org/patch/11459267/#23246825 Best regards, Yoshihiro Shimoda
