Re: [PATCH v6 2/2] iio: adc: Add MAX1241 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 2, 2020 at 9:55 PM Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> On 4/2/20 8:45 PM, Andy Shevchenko wrote:
> > On Wed, Apr 1, 2020 at 9:47 PM Alexandru Lazar <alazar@xxxxxxxxxxxxx> wrote:
> >> Add driver for the Maxim MAX1241 12-bit, single-channel ADC.
> >>
> > Perhaps put data sheet link as Datasheet: tag here?
> >
> >> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> >> Signed-off-by: Alexandru Lazar <alazar@xxxxxxxxxxxxx>
> > ...
> >
> >> +       indio_dev->name = spi_get_device_id(spi)->name;
> > Shouldn't be rather part number?
> > Jonathan?
>
> This is the part number as defined in the spi_device id table :)

Okay!

> +static const struct spi_device_id max1241_id[] = {
> +       { "max1241", max1241 },
> +       {}
> +};


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux