RE: [PATCH] arm64: dts: imx8m: Fix AIPS reg properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

> Subject: [PATCH] arm64: dts: imx8m: Fix AIPS reg properties
> 
> Commit dc3efc6ff0d5 ("arm64: dts: imx8m: fix aips dts node") caused several
> dtc warnings like these when building with W=1:
> 
> arch/arm64/boot/dts/freescale/imx8mm.dtsi:265.23-542.5: Warning
> (simple_bus_reg): /soc@0/bus@30000000: simple-bus unit address format
> error, expected "301f0000"
> arch/arm64/boot/dts/freescale/imx8mm.dtsi:544.23-602.5: Warning
> (simple_bus_reg): /soc@0/bus@30400000: simple-bus unit address format
> error, expected "305f0000"
> arch/arm64/boot/dts/freescale/imx8mm.dtsi:604.23-862.5: Warning
> (simple_bus_reg): /soc@0/bus@30800000: simple-bus unit address format
> error, expected "309f0000"
> arch/arm64/boot/dts/freescale/imx8mm.dtsi:864.23-909.5: Warning
> (simple_bus_reg): /soc@0/bus@32c00000: simple-bus unit address format
> error, expected "32df0000"
> 
> Fix them by using the correct address base and size in the AIPS reg properties.
> 
> Fixes: dc3efc6ff0d5 ("arm64: dts: imx8m: fix aips dts node")
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 8 ++++----
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 8 ++++----
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 +++---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++----
>  4 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index cc7152ecedd9..8829628f757a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -264,7 +264,7 @@
> 
>  		aips1: bus@30000000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x301f0000 0x10000>;
> +			reg = <0x30000000 0x400000>;

Should the node name changed to bus@0x301f0000, but not
change reg?

The 0x301f0000 is the correct aips configuration space.

Thanks,
Peng.

>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30000000 0x30000000 0x400000>; @@ -543,7
> +543,7 @@
> 
>  		aips2: bus@30400000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x305f0000 0x10000>;
> +			reg = <0x30400000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30400000 0x30400000 0x400000>; @@ -603,7
> +603,7 @@
> 
>  		aips3: bus@30800000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x309f0000 0x10000>;
> +			reg = <0x30800000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30800000 0x30800000 0x400000>, @@ -863,7
> +863,7 @@
> 
>  		aips4: bus@32c00000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x32df0000 0x10000>;
> +			reg = <0x32c00000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x32c00000 0x32c00000 0x400000>; diff --git
> a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index fa78f0163270..e62d4146cebc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -241,7 +241,7 @@
> 
>  		aips1: bus@30000000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x301f0000 0x10000>;
> +			reg = <0x30000000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> @@ -448,7 +448,7 @@
> 
>  		aips2: bus@30400000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x305f0000 0x10000>;
> +			reg = <0x30400000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> @@ -508,7 +508,7 @@
> 
>  		aips3: bus@30800000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x309f0000 0x10000>;
> +			reg = <0x30800000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> @@ -754,7 +754,7 @@
> 
>  		aips4: bus@32c00000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x32df0000 0x10000>;
> +			reg = <0x32c00000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..9f6ba763238d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -145,7 +145,7 @@
> 
>  		aips1: bus@30000000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x301f0000 0x10000>;
> +			reg = <0x30000000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> @@ -318,7 +318,7 @@
> 
>  		aips2: bus@30400000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x305f0000 0x400000>;
> +			reg = <0x30400000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> @@ -378,7 +378,7 @@
> 
>  		aips3: bus@30800000 {
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x309f0000 0x400000>;
> +			reg = <0x30800000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 75b384217a23..bab88369be1b 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -291,7 +291,7 @@
> 
>  		bus@30000000 { /* AIPS1 */
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x301f0000 0x10000>;
> +			reg = <0x30000000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30000000 0x30000000 0x400000>; @@ -696,7
> +696,7 @@
> 
>  		bus@30400000 { /* AIPS2 */
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x305f0000 0x10000>;
> +			reg = <0x30400000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30400000 0x30400000 0x400000>; @@ -756,7
> +756,7 @@
> 
>  		bus@30800000 { /* AIPS3 */
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x309f0000 0x10000>;
> +			reg = <0x30800000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x30800000 0x30800000 0x400000>, @@ -1029,7
> +1029,7 @@
> 
>  		bus@32c00000 { /* AIPS4 */
>  			compatible = "fsl,aips-bus", "simple-bus";
> -			reg = <0x32df0000 0x10000>;
> +			reg = <0x32c00000 0x400000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0x32c00000 0x32c00000 0x400000>;
> --
> 2.17.1





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux