Hi Neil, On Tue, Mar 31, 2020 at 9:44 AM Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: > > Hi, > > On 31/03/2020 00:11, Martin Blumenstingl wrote: > > Add the OPP table for the Mali-450 GPU and drop the hardcoded initial > > clock configuration. This enables GPU DVFS and thus saves power when the > > GPU is not in use while still being able switch to a higher clock on > > demand. > > > > While here, make most of meson-gxl-mali re-usable to reduce the amount > > of duplicate code between GXBB and GXL. This is more important now as we > > don't want to duplicate the GPU OPP table. > > Looks good, but please add comment about the CLKID_GP0_PLL assigned clock rate. I can do that - do you want that comment to be part of the patch description or in the .dtsi? > I'll ask LibreELEC people to have a run on these patches (including the clk changes) with Kodi. real-world testing would be amazing! Martin