Chen-Yu Tsai <wens@xxxxxxxx> [2020-03-31 09:19:57]: Hi, > On Tue, Mar 31, 2020 at 1:53 AM Maxime Ripard <maxime@xxxxxxxxxx> wrote: > > > > On Wed, Mar 25, 2020 at 09:59:24PM +0100, Petr Štetiar wrote: > > > There is a red LED marked as `GPIO_LED1` on the silkscreen and connected > > > to PE17 by default. So lets add this missing bit in the current hardware > > > description. > > > > > > Signed-off-by: Petr Štetiar <ynezz@xxxxxxx> > > > > QUeued for 5.8, thanks! > > The gpio-led binding seems to prefer "led-0" up to "led-f" (^led-[0-9a-f]) > as the child node name. This was recently brought to my attention. Do we > want to follow suit here? I can see following in Documentation/devicetree/bindings/leds/leds-gpio.yaml: patternProperties: # The first form is preferred, but fall back to just 'led' anywhere in the # node name to at least catch some child nodes. "(^led-[0-9a-f]$|led)": So it seems like `led-0` is indeed preferred, should I send v2 or a new patch as a fix on top of the previous one? -- ynezz