On Sat, Mar 28, 2020 at 4:07 PM Christian Lamparter <chunkeey@xxxxxxxxx> wrote: > > (Sorry for the bounces, yes my smarthost mail setup breaks from time to time > and I had to cut the CC since it complained about the length.) > > I guess we should think about upstreaming the MyBook Live DTS. Problem here > is that we deviated a bit from the canyonlands.dts/bluestone.dts structure > by having a skeleton apm82181.dtsi with most of the SoC defintition and a > wd-mybooklive.dts for the device. I don't see much of a problem with that. If the chips are quite different, then this would be the right way to do it, and it matches how most dts files are structured on arm and others as well. It would be nice to move over the the bluestone .dts to the apm82181.dtsi file when that gets added, if only to ensure they use the same description for each node, but that shouldn't stop the addition of the new file if that is needed for distros to make use of a popular device. I see a couple of additional files in openwrt [1], [obviously, I'm not actually the one in charge here, the decision is with the powerpc maintainers]. Arnd [1] https://git.openwrt.org/?p=openwrt/openwrt.git;a=tree;f=target/linux/apm821xx/dts;h=d359ba4ed83547438581dd40105e5100d8240beb;hb=HEAD