On Sat, 28 Mar 2020 12:52:11 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sat, Mar 28, 2020 at 2:12 AM Saravanan Sekar <sravanhome@xxxxxxxxx> wrote: > > > > Add support for 8-bit resolution ADC readings for input power > > supply and battery charging measurement. Provides voltage, current > > readings to mp2629 power supply driver. > > ... > > > + ret = regmap_read(info->regmap, chan->address, &rval); > > + if (ret < 0) > > ' < 0' is not needed for regmap call. > > .. > > > + case MP2629_INPUT_CURRENT: > > + *val = 133; > > + *val2 = 10; > > + return IIO_VAL_FRACTIONAL; > > + > > + default: > > + return -EINVAL; > > + } > > + > > + default: > > + return -EINVAL; > > + } > > > + > > + return 0; > > Do you really need this? Looks to me as dead code. > > ... > > > + indio_dev->name = dev_name(dev); > > Shouldn't be this a part number? > I heard something, so, I might be mistaken, but I hope maintainers > will help here. It should indeed. I have a nasty habit of missing this in review so thanks for pointing it out! Jonathan
