A note for Gregorii / bootlin people: After this patch, these still remain: arch/arm64/boot/dts/marvell/cn9131-db.dts: phy-mode = "10gbase-kr"; arch/arm64/boot/dts/marvell/armada-7040-db.dts: phy-mode = "10gbase-kr"; arch/arm64/boot/dts/marvell/armada-8040-db.dts: phy-mode = "10gbase-kr"; arch/arm64/boot/dts/marvell/armada-8040-db.dts: phy-mode = "10gbase-kr"; arch/arm64/boot/dts/marvell/cn9132-db.dts: phy-mode = "10gbase-kr"; arch/arm64/boot/dts/marvell/cn9130-db.dts: phy-mode = "10gbase-kr"; Please can you check whether these should be updated, and if so also update them? 10GBASE-KR is the backplane variant of 10GBASE-R which involves some negotiation. Thanks. On Fri, Mar 27, 2020 at 12:40:42PM +0000, Russell King wrote: > Update the SolidRun Armada 8040 platforms phy interface types from the > old 10gbase-kr to the newer and more correct 10gbase-r. > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 2 +- > arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts | 4 ++-- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > index 1e7b47affe26..006666272489 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts > @@ -401,7 +401,7 @@ > /* SFP */ > &cp0_eth0 { > status = "okay"; > - phy-mode = "10gbase-kr"; > + phy-mode = "10gbase-r"; > managed = "in-band-status"; > phys = <&cp0_comphy2 0>; > sfp = <&sfp_cp0_eth0>; > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts > index 26114d96d637..b44f4c029b78 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin-singleshot.dts > @@ -16,14 +16,14 @@ > > &cp0_eth0 { > status = "okay"; > - phy-mode = "10gbase-kr"; > + phy-mode = "10gbase-r"; > managed = "in-band-status"; > sfp = <&sfp_eth0>; > }; > > &cp1_eth0 { > status = "okay"; > - phy-mode = "10gbase-kr"; > + phy-mode = "10gbase-r"; > managed = "in-band-status"; > sfp = <&sfp_eth1>; > }; > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > index 087a5502631e..42741adf867b 100644 > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts > @@ -63,14 +63,14 @@ > status = "okay"; > /* Network PHY */ > phy = <&phy0>; > - phy-mode = "10gbase-kr"; > + phy-mode = "10gbase-r"; > }; > > &cp1_eth0 { > status = "okay"; > /* Network PHY */ > phy = <&phy8>; > - phy-mode = "10gbase-kr"; > + phy-mode = "10gbase-r"; > }; > > &cp1_pinctrl { > -- > 2.20.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up