On Fri, Mar 27, 2020 at 01:16:01PM +0200, Kalle Valo wrote: > <Ajay.Kathat@xxxxxxxxxxxxx> writes: > > > From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> > > > > This patch series is to review and move wilc1000 driver out of staging. > > Most of the review comments received in [1] & [2] are addressed in the > > latest code. Please review and provide your inputs. > > > > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@xxxxxxxxxxxxx/ > > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@xxxxxxxxxxxxx/ > > > > Changes since v5: > > - handle DT binding review comments suggested in below link: > > * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus > > - merged latest driver from staging which contains few cleanup patches > > and changes to use crc7 from existing library instead of having > > private implementation. > > This is already the third version this month, please avoid spamming the > list unnecessarily. What you can do to speed up the acceptance is to get > Reviewed-by tags from people, the more I see those the more confident I > get about the driver. I will also review this again once I find some > free time, but don't know when that will happen. > > But it would be good to document in the cover letter what commit id are > you using as the baseline. That way it's easy to review rest of the > changes Greg has applied separately and you don't need to resend the > whole driver everytime. Using the --base= flag in git format-patch is helpful in automating that :) thanks, greg k-h
