On Wed, 2020-03-25 at 12:59 +1100, Michael Ellerman wrote: > Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> writes: > > Add the d-cache/i-cache properties for the T208x SoCs. The L1 cache on > > these SoCs is 32KiB and is split into 64 byte blocks (lines). > > > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > > --- > > arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > LGTM. > > I'll wait a few days to see if Scott wants to ack it. > > cheers > > > > diff --git a/arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi > > b/arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi > > index 3f745de44284..2ad27e16ac16 100644 > > --- a/arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi > > +++ b/arch/powerpc/boot/dts/fsl/t208xsi-pre.dtsi > > @@ -81,6 +81,10 @@ cpus { > > cpu0: PowerPC,e6500@0 { > > device_type = "cpu"; > > reg = <0 1>; > > + d-cache-line-size = <64>; > > + i-cache-line-size = <64>; > > + d-cache-size = <32768>; > > + i-cache-size = <32768>; > > clocks = <&clockgen 1 0>; > > next-level-cache = <&L2_1>; > > fsl,portid-mapping = <0x80000000>; U-Boot should be setting d/i-cache-size and d/i-cache-block-size -- are you using something else? The line size is the same as the block size so we don't need a separate d/i- cache-line-size. -Scott