Hi Rob, On Montag, 23. März 2020 21:57:27 CET Rob Herring wrote: > On Mon, Mar 09, 2020 at 09:35:57PM +0100, Luca Weiss wrote: > > Add YAML devicetree binding for SGMICRO SGM3140 charge pump used for > > camera flash LEDs. > > > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > > --- > > Changes since RFC: > > - new patch > > > > I'm not sure about the completeness of this binding as it doesn't > > mention the led subnode at all. > > The only existing led yaml binding is leds/leds-max77650.yaml which > > mentions the subnode but duplicates properties from documented in > > leds/common.txt. > > It's common.yaml now. Reference it from a child node defined here. Thanks, that helps a lot! > > > .../bindings/leds/leds-sgm3140.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml Regards Luca
