Hi Rakesh, On Tue, Feb 4, 2020 at 5:21 AM Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote: > > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx> What is the status of this? Looks like you have some feedback from Sibi. Can you reply and spin this? Also a comment below: > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 +++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50a..167f68ac 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -287,6 +287,11 @@ > vdda-pll-supply = <&vreg_l4a_0p8>; > }; > > +&wifi { > + status = "okay"; > + qcom,msa-fixed-perm; > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qspi_clk { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 8011c5f..e3e8610 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -75,6 +75,11 @@ > reg = <0x0 0x80900000 0x0 0x200000>; > no-map; > }; > + > + wlan_fw_mem: memory@93900000 { > + reg = <0 0x93900000 0 0x200000>; > + no-map; > + }; > }; > > cpus { > @@ -1490,6 +1495,28 @@ > > #freq-domain-cells = <1>; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + reg = <0 0x18800000 0 0x800000>; > + reg-names = "membase"; > + iommus = <&apps_smmu 0xc0 0x1>; > + interrupts = > + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >, > + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >, > + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >, > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >, > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >, > + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >, > + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >, > + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >, > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >, > + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >, > + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>, > + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>; > + memory-region = <&wlan_fw_mem>; The clocks are missing: clocks = <&rpmhcc RPMH_RF_CLK2>; clock-names = "cxo_ref_clk_pin"; > + status = "disabled"; > + }; > }; > > thermal-zones { > -- > 2.7.4 >