Hello, On Tue, Mar 24, 2020 at 4:51 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Mar 23, 2020 at 04:45:01PM -0700, Rajat Jain wrote: > > Attach the firmware node to the serio i8042 kbd device so that device > > properties can be passed from the firmware. > > > > Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx> > > Change-Id: I36032f4bdee1dc52f26b57734068fd0ee7a6db0b > > Didn't you run checkpatch.pl on your patches which told you to remove > all of these Change-Id: values? My apologies. However I did run checkpatch.pl on my patches before sending (also checked just now again) and it did not complain about the Change-Id values in the commit log. Not sure if I'm running the command incorrectly? rajatja@rajat2:~/stock_kernel/linux$ ./scripts/checkpatch.pl ../patches/input_atkbd/v1/000* ----------------------------------------------------------------------------------------- ../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch ----------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 28 lines checked ../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch has no obvious style problems and is ready for submission. ----------------------------------------------------------------------------------------- ../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch ----------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 106 lines checked ../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch has no obvious style problems and is ready for submission. ...... <snip> ...... I will now resubmit the patches removing the Change-Id(s). Thanks & Best Regards, Rajat > > Please do so... > > greg k-h
