On Tue, Mar 24, 2020 at 11:50:24AM +0200, Andy Shevchenko wrote: > On Tue, Mar 24, 2020 at 10:32:19AM +0200, Matti Vaittinen wrote: > > +#include <linux/acpi.h> > > > +#include <linux/of.h> > > I didn't find any evidence of use of those two, otherwise, missed property.h > and perhaps mod_devicetable.h. ... > > +MODULE_DEVICE_TABLE(of, bd9995x_of_match); > > +MODULE_DEVICE_TABLE(acpi, bd9995x_acpi_match); I have to add since you are using those macros without ifdeffery, you should get warning in !ACPI and/or !OF cases. So, drop those of_match_ptr() / ACPI_PTR() and thus above headers. -- With Best Regards, Andy Shevchenko
