Dear Arnd Bergmann,
On Thu, 15 May 2014 15:26:29 +0200, Arnd Bergmann wrote:
> > +
> > + if (of_machine_is_compatible("marvell,armada375") ||
> > + of_machine_is_compatible("marvell,armada38x")) {
> > + arch_ioremap_caller = armada_pcie_wa_ioremap_caller;
> > + pci_ioremap_set_mem_type(MT_UNCACHED);
> > + mvebu_l2x0_pl310_coherent();
> > + }
> > +
> > l2x0_of_init(0, ~0UL);
>
>
> I wonder whether this should just be move to the existing
> armada_375_380_coherency_init() function to avoid the
> of_machine_is_compatible() check. Other than that,
Indeed, makes a lot of sense to have this in coherency.c instead. Will
be part of v4.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
