Luca
On 3/15/20 5:53 AM, Laurent Pinchart wrote:
Hi Luca,
On Sun, Mar 15, 2020 at 11:47:36AM +0100, Luca Weiss wrote:
On Mittwoch, 11. März 2020 13:49:35 CET Dan Murphy wrote:
On 3/9/20 3:35 PM, Luca Weiss wrote:
Add YAML devicetree binding for SGMICRO SGM3140 charge pump used for
camera flash LEDs.
Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
---
Changes since RFC:
- new patch
I'm not sure about the completeness of this binding as it doesn't
mention the led subnode at all.
The only existing led yaml binding is leds/leds-max77650.yaml which
mentions the subnode but duplicates properties from documented in
leds/common.txt.
.../bindings/leds/leds-sgm3140.yaml | 53 +++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml new file mode
100644
index 000000000000..be9384573d02
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-sgm3140.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: SGMICRO SGM3140 500mA Buck/Boost Charge Pump LED Driver
+
+maintainers:
+ - Luca Weiss <luca@xxxxxxxxx>
+
+description: |
+ The SGM3140 is a current-regulated charge pump which can regulate two
current + levels for Flash and Torch modes.
+
+ It is controlled with two GPIO pins.
Please define "It". Not sure what is controlled here.
"It" means the SGM3140. Not sure how else to write that or what the correct
term for such a component is.
Maybe "The device" ? I think Dan's concern is that he wasn't sure if
"It" referred to "the device" or to "flash and torch modes".
Laurent is correct. Are the flash and torch modes controlled by GPIOs
the device or the current levels?
