Geert Uytterhoeven, Mon, Mar 23, 2020 09:34:45 +0100: > On Fri, Mar 20, 2020 at 5:43 PM Alex Riesen <alexander.riesen@xxxxxxxxxxx> wrote: > > As all known variants of the Salvator board have the HDMI decoder > > chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482 > > endpoint and the connection definitions are placed in the common board > > file. > > For the same reason, the CLK_C clock line and I2C configuration (similar > > to the ak4613, on the same interface) are added into the common file. > > > > Signed-off-by: Alexander Riesen <alexander.riesen@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Did I provide a Reviewed-by? > > > The driver provides only MCLK clock, not the SCLK and LRCLK, > > which are part of the I2S protocol. > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Perhaps you mixed it up with Laurent's? Sorry. I actually did: he did provded Reviewed-by in his email, and you did not. I was ... a little overwhelmed. But you really did provide a lot of very useful information and it did help to improve the code. Shall I remove the tag still? Regards, Alex
