Hi, On Thursday, May 15, 2014 12:47:21 AM Rahul Sharma wrote: > From: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> > > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> > Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > > --- > .../devicetree/bindings/phy/samsung-phy.txt | 56 ++++++ > drivers/phy/Kconfig | 5 + > drivers/phy/Makefile | 1 + > drivers/phy/exynos-simple-phy.c | 189 ++++++++++++++++++++ > include/dt-bindings/phy/exynos-simple-phy.h | 27 +++ > 5 files changed, 278 insertions(+) > create mode 100644 drivers/phy/exynos-simple-phy.c > create mode 100644 include/dt-bindings/phy/exynos-simple-phy.h [...] > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 16a2f06..2a13e0d 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -178,4 +178,9 @@ config PHY_XGENE > help > This option enables support for APM X-Gene SoC multi-purpose PHY. > > +config EXYNOS_SIMPLE_PHY > + tristate "Exynos Simple PHY driver" Please limit this driver to EXYNOS platforms with: depends on ARCH_EXYNOS or (optionally) depends on ARCH_EXYNOS || COMPILE_TEST Moreover the generic PHY dependency is missing. It can be fixed with: select GENERIC_PHY > + help > + Support for 1-bit PHY controllers on SoCs from Exynos family. > + > endmenu Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html