Hi Laurent, Laurent Pinchart, Fri, Mar 20, 2020 10:59:07 +0100: > On Fri, Mar 20, 2020 at 10:03:39AM +0100, Alex Riesen wrote: > > Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100: > > > > > > You'd be surprised how many board designers would consider this a cheap > > > 12.288 MHz clock source, without using the I2S port ;-) > > > > Well, I am :-) > > > > Especially considering that the driver will not switch the MCLK pin aktive > > (all I2S-related pins are tristate by default). > > If the MCLK can't be output without enabling the I2S then I don't mind > if we make the #clock-cells optional, although, as Geert mentioned, > someone may still want to use it. So I settled on just removing the option. > > And how do I require it to be set unconditionally? By just removing the > > "if ..." part of the statement? > > Yes. For YAML it's easy too, the hard part is making properties > conditional :-) Converting it into YAML turned out a bit more than just reformatting: some of the explicit bindings schema is only implied in the text format :-( Takes a while to find out what is what. Regards, Alex
