Hi Stephen, Could you please take this patch-set to your tree if there are no further comments. Thanks, Chunyan On Wed, 4 Mar 2020 at 15:28, Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote: > > From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx> > > Add SC9863A specific clock driver and devicetree bindings for it, > this patch add to support the new way of specifying parents > without name strings of clocks. > > Also this patchset added support gate clock for pll which need to > wait a certain time for stable after being switched on. > > Changes from v5: > * Addressed comments from Rob: > - Removed description from "clock-names" and "reg" properties; > - Added maxItem to "reg" property. > * Modified the descriptions for those clocks which are a child node of > a syscon. > > Changes from v4: > * Fixed dt_binding_check warnings. > > Changes from v3: > * Rebased onto v5.6-rc1. > > Changes from v2: > * Addressed comments from Stephen: > - Remove ununsed header file from sc9863a-clk.c; > - Added comments for clocks which were marked with CLK_IGNORE_UNUSED, > and removed some unnecessary CLK_IGNORE_UNUSED; > - Added error checking for sprd_clk_regmap_init(). > > * Addressed comments from Rob: > - Put some clocks under syscon nodes, since these clocks have the same > physical address base with the syscon; > - Added clocks maxItems and listed out clock-names. > > * Added Rob's reviewed-by on patch 4. > > Changes from v1: > * Addressed comments: > - Removed redefine things; > - Switched DT bindings to yaml schema; > - Added macros for the new way of specifying clk parents; > - Switched to use the new way of specifying clk parents; > - Clean CLK_IGNORE_UNUSED flags for some SC9863A clocks; > - Dropped the module alias; > - Use device_get_match_data() instead of of_match_node(); > > * Added Rob's Acked-by on patch 2. > > Chunyan Zhang (6): > dt-bindings: clk: sprd: rename the common file name sprd.txt to SoC > specific > dt-bindings: clk: sprd: add bindings for sc9863a clock controller > clk: sprd: Add dt-bindings include file for SC9863A > clk: sprd: Add macros for referencing parents without strings > clk: sprd: support to get regmap from parent node > clk: sprd: add clocks support for SC9863A > > Xiaolong Zhang (1): > clk: sprd: add gate for pll clocks > > .../clock/{sprd.txt => sprd,sc9860-clk.txt} | 2 +- > .../bindings/clock/sprd,sc9863a-clk.yaml | 105 + > drivers/clk/sprd/Kconfig | 8 + > drivers/clk/sprd/Makefile | 1 + > drivers/clk/sprd/common.c | 10 +- > drivers/clk/sprd/composite.h | 39 +- > drivers/clk/sprd/div.h | 20 +- > drivers/clk/sprd/gate.c | 17 + > drivers/clk/sprd/gate.h | 120 +- > drivers/clk/sprd/mux.h | 28 +- > drivers/clk/sprd/pll.h | 55 +- > drivers/clk/sprd/sc9863a-clk.c | 1772 +++++++++++++++++ > include/dt-bindings/clock/sprd,sc9863a-clk.h | 334 ++++ > 13 files changed, 2457 insertions(+), 54 deletions(-) > rename Documentation/devicetree/bindings/clock/{sprd.txt => sprd,sc9860-clk.txt} (98%) > create mode 100644 Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.yaml > create mode 100644 drivers/clk/sprd/sc9863a-clk.c > create mode 100644 include/dt-bindings/clock/sprd,sc9863a-clk.h > > -- > 2.20.1 >