Hi Rob, On 3/18/20 5:40 PM, Rob Herring wrote: > On Tue, 17 Mar 2020 11:10:21 -0500, Dinh Nguyen wrote: >> Document the Agilex clock bindings, and add the clock header file. The >> clock header is an enumeration of all the different clocks on the Agilex >> platform. >> >> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx> >> --- >> v3: address comments from Stephen Boyd >> fix build error(tab removed in line 37) >> renamed to intel,agilex.yaml >> v2: convert original document to YAML >> --- >> .../bindings/clock/intel,agilex.yaml | 36 ++++++++++ >> include/dt-bindings/clock/agilex-clock.h | 70 +++++++++++++++++++ >> 2 files changed, 106 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/intel,agilex.yaml >> create mode 100644 include/dt-bindings/clock/agilex-clock.h >> > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/clock/intel,agilex.example.dts:17.3-4 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/clock/intel,agilex.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/clock/intel,agilex.example.dt.yaml] Error 1 > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1256630 > Please check and re-submit. > I want to be able check these errors locally before sending the next version. But I keep getting various errors when I try to "make dt_binding_check": Traceback (most recent call last): File "/bin/dt-doc-validate", line 15, in <module> import ruamel.yaml ImportError: No module named 'ruamel' Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/arm/l2c2x0.example.dts' failed Do you have a pointer on how to run the dt_binding_check? Thanks, Dinh
