Hi Andy, On Thu, 2020-03-19 at 13:36 +0200, Andy Shevchenko wrote: > On Thu, Mar 19, 2020 at 06:03:35PM +0800, Dongchun Zhu wrote: > > On Tue, 2020-03-10 at 12:10 +0200, Andy Shevchenko wrote: > > > On Thu, Mar 5, 2020 at 2:07 PM Sakari Ailus > > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > > > On Fri, Feb 28, 2020 at 11:59:58PM +0800, Dongchun Zhu wrote: > > > > > This patch adds a V4L2 sub-device driver for DW9768 lens voice coil, > > > > > and provides control to set the desired focus via I2C serial interface. > > > > > > ... > > > > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -5139,6 +5139,7 @@ M: Dongchun Zhu <dongchun.zhu@xxxxxxxxxxxx> > > > > > L: linux-media@xxxxxxxxxxxxxxx > > > > > T: git git://linuxtv.org/media_tree.git > > > > > S: Maintained > > > > > +F: drivers/media/i2c/dw9768.c > > > > > F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > > > > > This has ordering issues. > > > Run parse-maintainers.pl to fix. > > > > > > > Pardon, how to run parse-maintainers.pl? > > Locally I ran this script, it occurs some syntax as below. > > $./scripts/parse-maintainers.pl > > It's a perl script which is made non-executable by some reason. > > So, proper run as a parameter to the language interpreter, i.e. > $ perl scripts/parse-maintainer.pl > I tried-run again on mtk server, which has perl5(version 18.2). But it still report the same error. Is there any requirement for perl version? $perl scripts/parse-maintainers.pl syntax error at scripts/parse-maintainers.pl line 108, near "$hashref{" Global symbol "$pattern" requires explicit package name at scripts/parse-maintainers.pl line 109. syntax error at scripts/parse-maintainers.pl line 112, near "}" Global symbol "$file" requires explicit package name at scripts/parse-maintainers.pl line 113. Can't use global @_ in "my" at scripts/parse-maintainers.pl line 117, near "(@_" syntax error at scripts/parse-maintainers.pl line 152, near "}" Execution of scripts/parse-maintainers.pl aborted due to compilation errors. Local perl version is as below. $ls -al /usr/bin/perl perl perl5.18.2