Quoting Maulik Shah (2020-03-17 21:29:15) > From: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx> > > Add device binding documentation for Qualcomm Technologies, Inc. (QTI) > SoC sleep stats driver. The driver is used for displaying SoC sleep > statistic maintained by Always On Processor or Resource Power Manager. > > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Mahesh Sivasubramanian <msivasub@xxxxxxxxxxxxxx> > Signed-off-by: Lina Iyer <ilina@xxxxxxxxxxxxxx> > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > --- Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Two nits below. > diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > new file mode 100644 > index 0000000..d0c751d > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > @@ -0,0 +1,46 @@ [...] > + > +examples: > + # Example of rpmh sleep stats > + - | > + rpmh-sleep-stats@c3f0000 { I would think 'memory' would be a more appropriate node name, but OK. > + compatible = "qcom,rpmh-sleep-stats"; > + reg = <0 0xc3f0000 0 0x400>; Please add a leading 0 to the address to pad it out to 8 digits. > + };