Re: [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

Thank you for the patch.

On Sat, Mar 14, 2020 at 04:30:46PM +0100, Sam Ravnborg wrote:
> The "data-mapping" property may not be the best way to describe the
> interface between panels and display interfaces.
> Drop use of in the panel-simple driver, so we have time to find
> the right way to describe this interface.

For the same reason as for patch 1/3,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 0ce81b1f36af..3ad828eaefe1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -361,7 +361,6 @@ static int panel_dpi_probe(struct device *dev,
>  	struct panel_desc *desc;
>  	unsigned int bus_flags;
>  	struct videomode vm;
> -	const char *mapping;
>  	int ret;
>  
>  	np = dev->of_node;
> @@ -386,16 +385,6 @@ static int panel_dpi_probe(struct device *dev,
>  	of_property_read_u32(np, "width-mm", &desc->size.width);
>  	of_property_read_u32(np, "height-mm", &desc->size.height);
>  
> -	of_property_read_string(np, "data-mapping", &mapping);
> -	if (!strcmp(mapping, "rgb24"))
> -		desc->bus_format = MEDIA_BUS_FMT_RGB888_1X24;
> -	else if (!strcmp(mapping, "rgb565"))
> -		desc->bus_format = MEDIA_BUS_FMT_RGB565_1X16;
> -	else if (!strcmp(mapping, "bgr666"))
> -		desc->bus_format = MEDIA_BUS_FMT_RGB666_1X18;
> -	else if (!strcmp(mapping, "lvds666"))
> -		desc->bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
> -
>  	/* Extract bus_flags from display_timing */
>  	bus_flags = 0;
>  	vm.flags = timing->flags;

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux