On Thu, May 15, 2014 at 10:24:39AM +0200, Stefan Agner wrote: > Hi Thierry, hi Philipp, > > Am 2014-05-15 09:51, schrieb Thierry Reding: > > On Wed, May 14, 2014 at 11:45:57PM +0200, stefan@xxxxxxxx wrote: > >> From: Stefan Agner <stefan@xxxxxxxx> > >> > >> This panels are sold by Toradex for Colibri T20/T30 and Apalis T30 > >> evaluation kits. > >> > >> Signed-off-by: Stefan Agner <stefan@xxxxxxxx> > > > > Panel patches should go to the dri-devel mailing list as well. > > > > Also a patch was posted only yesterday for a panel that seems to be the > > exact same one as this, even though the name differs minimally, see: > > > > https://patchwork.kernel.org/patch/4175251/ > > > > Adding Philipp on Cc so you guys can work together whether this is > > indeed the same panel. The only differences seem to be in the vertical > > front and back porches, but I suspect that either settings will work on > > both Tegra and i.MX. > > Its etm0700g0dh6 vs. et070080dh6, Philipp's panel is with captive multi > touch, (hence the M I guess). The panel itself really looks the same. > > I found this overview of EDT displays: > http://www.dmbtechnics.com/scripts/passthru.php?id=7 > > There seem to be quite a lot variants with the same panel... > > Regarding timings, I just checked the documentation, Philipp's timing > really matches the documented ones, I miscalculated the vertical back > porch. Okay, so that means that the panel works for you with the same timings that Philipp has in the ETM0700G0DH6 patch? If so then I definitely think we should be sharing the timings in the driver by making the two compatible entries point to the same driver data. > How do we resolve that? > > I would suggest that I split out that patch and remove the et070080dh6 > panel and send the other as a single patch to the dri-devel mailing list > as well. Yes, that would work. > Philipp, could you add my display type (et070080dh6) to the compatible > list of your mode/panel entry? I also noticed that Philipp's patch doesn't actually introduce the device tree bindings, so that will have to be added as well. Thierry
Attachment:
pgpr5WdCNDd8s.pgp
Description: PGP signature
