Re: [PATCH v3 06/12] spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 16 Mar 2020 at 14:49, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Mon, Mar 16, 2020 at 02:29:09PM +0200, Vladimir Oltean wrote:
>
> > Correct, the real problem is that I forgot to add a Fixes: tag for
> > patch 5. I'll do that now.
>
> OK.  The series otherwise looked fine but I'll wait for testing.
> Michael, if there's issues remaining it might be good to get some
> Tested-bys for the patches prior to whatever's broken so we can get
> those fixes in (but obviously verifying that is work so only if you
> have time).

This time I verified with a protocol analyzer all transfer lengths
from 1 all the way to 256, with this script:

#!/bin/bash

buf=''

for i in $(seq 0 255); do
»       buf="${buf}\x$(printf '%02x' ${i})"
»       spidev_test --device /dev/spidev2.0 --bpw 8 --cpha --speed
5000000 -p "${buf}"
done

It looked fine as far as I could tell, and also the problems
surrounding Ctrl-C are no longer present. Nonetheless it would be good
if Michael could confirm, but I know that he's very busy too so it's
understandable if he can no longer spend time on this.

Thanks,
-Vladimir




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux