Hi Tomi. Thanks for your feedback. On Mon, Mar 16, 2020 at 09:57:57AM +0200, Tomi Valkeinen wrote: > Hi Sam, > > On 15/03/2020 15:44, Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > --- > > .../display/panel/lgphilips,lb035q02.txt | 33 ------------ > > .../display/panel/lgphilips,lb035q02.yaml | 54 +++++++++++++++++++ > > 2 files changed, 54 insertions(+), 33 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > create mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > deleted file mode 100644 > > index 1a1e653e5407..000000000000 > > --- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.txt > > +++ /dev/null > > @@ -1,33 +0,0 @@ > > -LG.Philips LB035Q02 Panel > > -========================= > > - > > -Required properties: > > -- compatible: "lgphilips,lb035q02" > > -- enable-gpios: panel enable gpio > > - > > -Optional properties: > > -- label: a symbolic name for the panel > > - > > -Required nodes: > > -- Video port for DPI input > > Isn't this also compatible with panel-simple bindings? 'label' is the only > one not in panel-simple, but that's optional and has never been used by the > panel driver. The panel is a SPI slave - which is not too obvious from the old binding. The new DT Schema includes spi/spi-slave.yaml to give the binding proper access to the spi slave properties. That would not be possible with panel-simple binding as no further properties are allowed with the panel-simple binding. I hope this explains why there is a dedicated binding for this panel. Sam
