On Fri, 13 Mar 2020 19:55:06 +0200 Grygorii Strashko wrote: > +static void am65_cpsw_nuss_free_tx_chns(void *data) > +{ > + struct am65_cpsw_common *common = data; > + int i; > + > + for (i = 0; i < common->tx_ch_num; i++) { > + struct am65_cpsw_tx_chn *tx_chn = &common->tx_chns[i]; nit: stray tab? > + > + if (!IS_ERR_OR_NULL(tx_chn->tx_chn)) > + k3_udma_glue_release_tx_chn(tx_chn->tx_chn); > + > + if (!IS_ERR_OR_NULL(tx_chn->desc_pool)) > + k3_udma_desc_pool_destroy(tx_chn->desc_pool); > + > + memset(tx_chn, 0, sizeof(*tx_chn)); > + }; nit: you also got some stray semicolons in a few places Thanks for the changes, looks better. Hopefully someone who knows the HW better can have a look as well.