Hi Rahul, Tomasz, On 14.05.2014 21:17, Rahul Sharma wrote: > From: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> > > Add exynos-simple-phy driver to support a single register > PHY interfaces present on Exynos4 SoC. > > Signed-off-by: Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx> > Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > > --- > .../devicetree/bindings/phy/samsung-phy.txt | 56 ++++++ > drivers/phy/Kconfig | 5 + > drivers/phy/Makefile | 1 + > drivers/phy/exynos-simple-phy.c | 189 ++++++++++++++++++++ > include/dt-bindings/phy/exynos-simple-phy.h | 27 +++ > 5 files changed, 278 insertions(+) > create mode 100644 drivers/phy/exynos-simple-phy.c > create mode 100644 include/dt-bindings/phy/exynos-simple-phy.h > > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index 2049261..12ad9cf 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt > @@ -161,3 +161,59 @@ Example: > usbdrdphy0 = &usb3_phy0; > usbdrdphy1 = &usb3_phy1; > }; > + > +Samsung S5P/EXYNOS SoC series SIMPLE PHY > +------------------------------------------------- > + > +Required properties: > +- compatible : should be one of the listed compatibles: > + - "samsung,exynos4210-simple-phy" > + - "samsung,exynos4412-simple-phy" > + - "samsung,exynos5250-simple-phy" > + - "samsung,exynos5420-simple-phy" > +- samsung,pmureg-phandle - handle to syscon to control PMU registers > +- #phy-cells : from the generic phy bindings, must be 1; > + > +For "samsung,exynos4210-simple-phy" compatible PHYs the second cell in > +the PHY specifier identifies the PHY and the supported phys for exynos4210 > +are: > + HDMI_PHY, > + DAC_PHY, > + ADC_PHY, > + PCIE_PHY, > + SATA_PHY. > + > +For "samsung,exynos4412-simple-phy" compatible PHYs the second cell in > +the PHY specifier identifies the PHY and the supported phys for exynos4412 > +are: > + HDMI_PHY, > + ADC_PHY. > + > +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in > +the PHY specifier identifies the PHY and the supported phys for exynos5250 > +are: > + HDMI_PHY, > + ADC_PHY, > + SATA_PHY. > + > +For "samsung,exynos5420-simple-phy" compatible PHYs the second cell in > +the PHY specifier identifies the PHY and the supported phys for exynos5420 > +are: > + HDMI_PHY, > + ADC_PHY. > + > +Example: > +Simple PHY provider node: > + > + simplephys: simple-phys@10040000 { > + compatible = "samsung,exynos5250-simple-phy"; Missing reg property or unnecessary @unit-address suffix in node name. > + samsung,pmu-syscon = <&pmu_system_controller>; > + #phy-cells = <1>; > + }; In general, the idea is quite good, but I think this should rather bind to the main PMU node, since this is just a part of the PMU, not another device in the system. This also means that the PMU node itself should be the PHY provider. Otherwise looks good. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html