Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: > From: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > > Enable hdmi for peach-pi board. > > Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 742655b..2a6f23b8 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -134,6 +134,25 @@ > }; > }; > > +&i2c_2 { > + status = "okay"; > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-max-bus-freq = <66000>; > + samsung,i2c-slave-addr = <0x50>; > + > + hdmiddc@50 { > + reg = <0x50>; > + }; > +}; > + > +&hdmi { > + status = "okay"; > + hpd-gpio = <&gpx3 7 2>; What is the 2 flag? I don't see any value other than 0 and 1 defined in include/dt-bindings/gpio/gpio.h. Also it would be better to use preprocessor macros instead of magic numbers for flags like this. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html