Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: > From: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > > "gpx3-7" is chip specific pin in Exynos5420 for hdmi > hotplug. This pin is moved to exynos5420-pinctrl.dts > and removed from the board file. > > Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 6910485..11cd9bf 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -131,15 +131,6 @@ > }; > }; > > - pinctrl@13400000 { > - hdmi_hpd_irq: hdmi-hpd-irq { > - samsung,pins = "gpx3-7"; > - samsung,pin-function = <0>; > - samsung,pin-pud = <1>; > - samsung,pin-drv = <0>; Again, the same comment as for patch 1/5. This pin is being configured as input, which doesn't look like a dedicated special function pin. Shouldn't this node rather stay here? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html