On Wed, Mar 11, 2020 at 12:18:30PM +0200, Andy Shevchenko wrote: > On Wed, Mar 11, 2020 at 10:30:43AM +0100, Tobias Schramm wrote: ... > > + ret = device_property_read_u32_array(dev, > > + "cellwise,monitor-interval-ms", > > It's fine to have it on one line. > > > + &value, 1); Actually this is simple ret = device_property_read_u32(dev, "cellwise,monitor-interval-ms", &value); (You can use one or two lines on your choice) -- With Best Regards, Andy Shevchenko