On Tue, Feb 25, 2020 at 11:44:02AM +0800, peng.fan@xxxxxxx wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > Per binding doc fsl,aips-bus.yaml, compatible and reg is > required. And for reg, the AIPS configuration space should be > used, not all the AIPS bus space. > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 12 ++++++++---- > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++-------- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 12 ++++++++---- > 4 files changed, 30 insertions(+), 22 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index b3d0b29d7007..a4356d2047cd 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -227,7 +227,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; The binding doc says "fsl,aips-bus", not "fsl,aips". Shawn > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -496,7 +497,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -555,7 +557,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>; > @@ -800,7 +803,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index f2775724377f..4848ce82f083 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -203,8 +203,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -401,8 +401,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -461,8 +461,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -707,8 +707,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > - reg = <0x32c00000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 71b0c8f23693..eb67f56cdfe2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -144,8 +144,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -309,8 +309,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -369,8 +369,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 6a1e83922c71..07070464063d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -290,7 +290,8 @@ > dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>; > > bus@30000000 { /* AIPS1 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -692,7 +693,8 @@ > }; > > bus@30400000 { /* AIPS2 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -751,7 +753,8 @@ > }; > > bus@30800000 { /* AIPS3 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>, > @@ -1023,7 +1026,8 @@ > }; > > bus@32c00000 { /* AIPS4 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > -- > 2.16.4 >