On Mon, Mar 09, 2020 at 06:07:51PM +0100, Uwe Kleine-König wrote:
> On Mon, Mar 09, 2020 at 04:45:05PM +0000, Philippe Schenker wrote:
> > On Mon, 2020-03-09 at 14:55 +0000, Paul Barker wrote:
> >> The pwm-imx27 driver supports a third argument in a pwms reference to
> >> provide flags. However #pwm-cells needs to be set to <3> in the pwm
> >> node
> >> so that these flags can be passed through to the driver. Once #pwm-
> >> cells
> >> is <3>, all pwms references need to use the 3-cell form.
> >>
> >> Signed-off-by: Paul Barker <pbarker@xxxxxxxxxxxx>
> >>
> >> Cc: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>
> >> Cc: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
> >> Cc: Rob Herring robh+dt@xxxxxxxxxx
> >> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> >> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> >> ---
> >> arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 2 +-
> >> arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 2 +-
> >> arch/arm/boot/dts/imx6dl-mamoj.dts | 2 +-
> >> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 1 -
> >> arch/arm/boot/dts/imx6q-ba16.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6q-display5.dtsi | 1 -
> >> arch/arm/boot/dts/imx6q-kp.dtsi | 4 ++--
> >> arch/arm/boot/dts/imx6q-logicpd.dts | 2 +-
> >> arch/arm/boot/dts/imx6q-mccmon6.dts | 1 -
> >> arch/arm/boot/dts/imx6q-novena.dts | 2 +-
> >> arch/arm/boot/dts/imx6q-pistachio.dts | 2 +-
> >> arch/arm/boot/dts/imx6q-var-dt6customboard.dts | 2 +-
> >> arch/arm/boot/dts/imx6qdl-apalis.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-apf6dev.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-emcon.dtsi | 6 +++---
> >> arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-icore.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi | 4 ++--
> >> arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 6 +++---
> >> arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi | 4 ++--
> >> arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 4 ++--
> >> arch/arm/boot/dts/imx6qdl-phytec-mira.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 6 +++---
> >> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6qdl-tx6.dtsi | 2 --
> >> arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++----
> >> arch/arm/boot/dts/imx6sl-evk.dts | 2 +-
> >> arch/arm/boot/dts/imx6sl.dtsi | 8 ++++----
> >> arch/arm/boot/dts/imx6sll-evk.dts | 2 +-
> >> arch/arm/boot/dts/imx6sll.dtsi | 8 ++++----
> >> arch/arm/boot/dts/imx6sx-nitrogen6sx.dts | 2 +-
> >> arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 6 +++---
> >> arch/arm/boot/dts/imx6sx.dtsi | 16 ++++++++-------
> >> -
> >> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 2 +-
> >> arch/arm/boot/dts/imx6ul-geam.dts | 2 +-
> >> arch/arm/boot/dts/imx6ul-imx6ull-opos6uldev.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6ul-isiot.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6ul-kontron-n6310-s-43.dts | 2 +-
> >> arch/arm/boot/dts/imx6ul-kontron-n6x1x-s.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6ul-pico.dtsi | 2 +-
> >> arch/arm/boot/dts/imx6ul-tx6ul.dtsi | 1 -
> >> arch/arm/boot/dts/imx6ul.dtsi | 16 ++++++++-------
> >> -
> >> arch/arm/boot/dts/imx6ull-colibri.dtsi | 4 ----
> >> 56 files changed, 85 insertions(+), 95 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
> >> b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
> >> index 37f80ab8ccd0..f87ac95b70bc 100644
> >> --- a/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
> >> +++ b/arch/arm/boot/dts/imx6dl-aristainetos_4.dts
> >> @@ -14,7 +14,7 @@
> >>
> >> backlight {
> >> compatible = "pwm-backlight";
> >> - pwms = <&pwm1 0 5000000>;
> >> + pwms = <&pwm1 0 5000000 0>;
> >
> > There is a header file existing that has PWM_POLARITY_INVERTED defined
> > in include/dt-bindings/pwm/pwm.h. I feel we should add there a
> > PWM_POLARITY_NORMAL instead of just using 0.
>
> ack.
>
> > But then I'm asking myself if we can't get rid of the file include/dt-
> > bindings/pwm/pwm.h and instead use include/linux/pwm.h everywhere.
> >
> > Or shouldn't we use defines in devicetrees from there?
>
> devicetrees are supposed to be stand-alone. So yes indeed, no linux
> includes in device tree files.
Correct. I don't mind adding PWM_POLARITY_NORMAL to
include/dt-bindings/pwm/pwm.h, I think it would increase readability.
--
Regards,
Laurent Pinchart
