Re: [PATCH] dts: imx6: Allow flags argument in pwms reference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

while I like the result in general I'd be a bit more careful here. So
I'd split this into several steps:

  a) add
	#pwm-cells = <3>;
     to the soc.dtsi and undo this by adding
	#pwm-cells = <2>;
     to all machine.dts (that don't already have #pwm-cells = <3>)

  b) for each machine with explicit #pwm-cells = <2>; convert to ... =
     <3>;.

This has the advantage that after a) there are no changes to the .dtb
files which can be easily verified. And the patches in b) can be
individually reverted in case something machine specific breaks.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux