On Fri, 06 Mar 2020, Sergey.Semin@xxxxxxxxxxxxxxxxxxxx wrote: > From: Serge Semin <fancer.lancer@xxxxxxxxx> > > A lot of custom functionality can be tuned by means of a syscon-registers > placed in Baikal-T1 CCU memory space (though in documentation they are > called system devices registers). While in most of the case the syscon > registers usage will be distributed between corresponding subsystem drivers > (thanks to pretty much coherent design of the registers fields), there are > some peculiarities we should reflect in the generic syscon code. > > First of all seeing there is an map endiannes config acceptable by the syscon > it would be justified to add the corresponding properties declared in the > mfd/syscon.yaml bindings file. Don't really know why this hasn't been done > before. > > Then as it's going to be general in the framework of the Baikal-T1 SoC support > integration into the kernel, we suggest to replace the legacy text-based > syscon-reboot-mode dts-bindings file with yaml-based one. > > Finally seeing the syscon-reboot-mode devices are mostly used in conjuction > with just syscon-reboot device (in particular Baikal-T1 CCU WDT RCR register is > preserved during any type of reboots) and for several other reasons (see the > commit message for details), we suggest to add the 'regmap' property support > to the syscon-reboot-mode driver. This would eliminate the requirement of > placing the syscon-reboot-mode dts-node in the syscon sub-nodes area. > > This patchset is rebased and tested on the mainline Linux kernel 5.6-rc4: > commit 98d54f81e36b ("Linux 5.6-rc4"). > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > Cc: Maxim Kaurkin <Maxim.Kaurkin@xxxxxxxxxxxxxxxxxxxx> > Cc: Pavel Parkhomenko <Pavel.Parkhomenko@xxxxxxxxxxxxxxxxxxxx> > Cc: Ramil Zaripov <Ramil.Zaripov@xxxxxxxxxxxxxxxxxxxx> > Cc: Ekaterina Skachko <Ekaterina.Skachko@xxxxxxxxxxxxxxxxxxxx> > Cc: Vadim Vlasov <V.Vlasov@xxxxxxxxxxxxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: Paul Burton <paulburton@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > Cc: Sebastian Reichel <sre@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-pm@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Serge Semin (4): > dt-bindings: syscon: Add syscon endian properties support > dt-bindings: power: reset: Replace SYSCON reboot-mode legacy bindings > with YAML-based one > dt-bindings: power: reset: Add regmap support to the SYSCON > reboot-mode bindings > power: reset: syscon-reboot-mode: Add regmap dts-property support > > .../devicetree/bindings/mfd/syscon.yaml | 14 +++++ > .../power/reset/syscon-reboot-mode.txt | 35 ----------- > .../power/reset/syscon-reboot-mode.yaml | 58 +++++++++++++++++++ > drivers/power/reset/syscon-reboot-mode.c | 11 +++- > 4 files changed, 80 insertions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.txt > create mode 100644 Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml Please re-send this patch --threaded. As it stands, it's been scattered to the 4 winds throughout my inbox. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog