On Thu, 05 Mar 2020, Enric Balletbo i Serra wrote: > Hi Ikjoon, > > On 5/3/20 8:53, Ikjoon Jang wrote: > > Convert the ChromeOS EC bindings to json-schema. > > > > Signed-off-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx> > > --- > > v6: adjust property dependencies, drop duplicated definitions, > > and set additionalProperties > > v5: unset additionalProperties > > v4: text reflows, add type references, and fix examples > > v3: node name changed in rpmsg example > > v2: cleanup description, fix typos, remove LPC, and add RPMSG example > > --- > > .../devicetree/bindings/mfd/cros-ec.txt | 76 ----------- > > .../devicetree/bindings/mfd/cros-ec.yaml | 125 ++++++++++++++++++ > > According to the feedback I received on other patches from Rob, the name of the > file should include the vendor, in that case should be google,cros-ec.yaml > > I already argued in previous version why I think this should go in > bindings/chrome instead of mfd, these bindings correspond to the platform/chrome > device not the mfd cros ec device (cros-ec-dev) in MFD, anyway, I don't want to > be touchy, but, as is, should go through the Lee Jones tree not our > chrome-platform tree. So if Lee is fine with it I'm fine too. Actually these have been reviewed and taken by Rob of late. > Just another minor change (see below) and looks good to me. > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
