On Thu, Mar 5, 2020 at 6:50 AM Amit Kucheria <amit.kucheria@xxxxxxxxxx> wrote: > > On Tue, Feb 25, 2020 at 12:10 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Mon, 24 Feb 2020 12:55:37 +0530, Amit Kucheria wrote: > > > As part of moving the thermal bindings to YAML, split it up into 3 > > > bindings: thermal sensors, cooling devices and thermal zones. > > > > > > The thermal-zone binding is a software abstraction to capture the > > > properties of each zone - how often they should be checked, the > > > temperature thresholds (trips) at which mitigation actions need to be > > > taken and the level of mitigation needed at those thresholds. > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx> > > > --- > > > .../bindings/thermal/thermal-zones.yaml | 302 ++++++++++++++++++ > > > 1 file changed, 302 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > This one isn't due to my patch, I believe. Right, that's the one known warning... > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupt-names: ['uplow'] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupts: [[0, 506, 4]] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupt-names: ['uplow'] is too short > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupts: [[0, 507, 4]] is too short > > Fixed. Just for my information, did the check somehow figure out that > this (incomplete) example needed the qcom-tsens.yaml binding (based on > compatible string?) and then apply those rules to throw this error? Yes. And setting DT_SCHEMA_FILES did change that to only check with the specified schema file. However, that's now changed in linux-next such that examples are always checked by all schemas and DT_SCHEMA_FILES just limits which bindings to build and check. Rob
