On Wed, May 14, 2014 at 9:55 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be > updated. > > Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource allocation') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > index c522c4f..bd32257 100644 > --- a/drivers/usb/phy/phy-msm-usb.c > +++ b/drivers/usb/phy/phy-msm-usb.c > @@ -1587,8 +1587,8 @@ static int msm_otg_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > motg->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); > - if (IS_ERR(motg->regs)) > - return PTR_ERR(motg->regs); > + if (!motg->regs) > + return -ENOMEM; What about doing devm_ioremap_resource() instead? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html