Hi Geert, > > > > + reg = <0x44>; > > > > + interrupt-parent = <&gpio4>; > > > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > > > > > This should be "<4 IRQ_TYPE_LEVEL_LOW>", to refer to GP4_4. > > > > Indeed, I will fix it in v2. > > > > > > > > > + irq-gpio = <&gpio4 4 IRQ_TYPE_LEVEL_LOW>; > > > > > > "irq-gpio" is not documented in the DT bindings. > > > > See "Documentation/devicetree/bindings/mfd/stmpe.txt" > > I believe you cannot use the same GPIO as an interrupt and as a GPIO at the > same time. Don't you get a -EBUSY somewhere? > Perhaps it worked due to the typo above? > > As both interrupts and irq-gpio are documented to be optional properties, > probably they are mutually exclusive, and you can drop irq-gpio? Yes, this is redundant. They are mutually exclusive in the driver code with irq-gpio having precedence over the interrupts/interrupt-parent registration. Therefore, I will remove the irq-gpio property as interrupts/interrupt-parent pair does the job. Thank you, Marian
