> -----Original Message----- > From: Michael Walle <michael@xxxxxxxx> > Sent: Tuesday, March 3, 2020 11:43 AM > To: linux-serial@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Shawn > Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Jiri Slaby > <jslaby@xxxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Vabhav Sharma > <vabhav.sharma@xxxxxxx>; Yuan Yao <yao.yuan@xxxxxxx>; Michael Walle > <michael@xxxxxxxx> > Subject: [PATCH v3 8/9] arm64: dts: ls1028a: add "fsl,vf610-edma" compatible > > The bootloader does the IOMMU fixup and dynamically adds the "iommus" > property to devices according to its compatible string. In case of the eDMA > controller this property is missing. Add it. After that the IOMMU will work > with the eDMA core. It probably makes sense to have the fsl,vf610-edma as a secondary compatible. But I think it probably need an update to the binding document too(especially the compatible is required to function). Also looks like the recent update for the binding has a typo for " fsl,fsl,ls1028a-edma", can you also fix that all together? > > Signed-off-by: Michael Walle <michael@xxxxxxxx> > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 0bf375ec959b..0843cfbe7ae1 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -335,7 +335,7 @@ > > edma0: dma-controller@22c0000 { > #dma-cells = <2>; > - compatible = "fsl,ls1028a-edma"; > + compatible = "fsl,ls1028a-edma", "fsl,vf610-edma"; > reg = <0x0 0x22c0000 0x0 0x10000>, > <0x0 0x22d0000 0x0 0x10000>, > <0x0 0x22e0000 0x0 0x10000>; > -- > 2.20.1