Hi Thomas, > Am 03.03.2020 um 11:18 schrieb Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>: > > On Sat, Feb 29, 2020 at 08:45:45PM +0100, H. Nikolaus Schaller wrote: >> There is a ACT8600 on the CI20 board and the bindings of the >> ACT8865 driver have changed without updating the CI20 device >> tree. Therefore the PMU can not be probed successfully and >> is running in power-on reset state. >> >> Fix DT to match the latest act8865-regulator bindings. >> >> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") > > I see checkpatch warnings in this patch, could please fix them ? Ah, ok. The comment. Well, on a 5k screen this 80 character limit is really outdated. But checkpatch is the king :) Noted for v6. > And please seperate fixes from improvments, thank you. What do you mean by "separate"? Two separate patches? This patch only contains fixes (which I would consider all of them to be improvements). > > Thomas. BR and thanks, Nikolaus