On 13/05/14 19:23, Alexander Shiyan wrote: > Tue, 13 May 2014 19:09:30 +0200 от Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>: >> > Hi, >> > >> > On 02/05/14 09:18, Alexander Shiyan wrote: >>> > > This patch adds devicetree support for the Freescale enhanced Multimedia >>> > > Accelerator (eMMA) video Pre-processor (PrP). >>> > > >>> > > Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx> >>> > > --- >>> > > .../devicetree/bindings/media/fsl-imx-emmaprp.txt | 19 +++++++++++++++++++ >>> > > drivers/media/platform/mx2_emmaprp.c | 8 ++++++++ >>> > > 2 files changed, 27 insertions(+) >>> > > create mode 100644 Documentation/devicetree/bindings/media/fsl-imx-emmaprp.txt >>> > > >>> > > diff --git a/Documentation/devicetree/bindings/media/fsl-imx-emmaprp.txt b/Documentation/devicetree/bindings/media/fsl-imx-emmaprp.txt >>> > > new file mode 100644 >>> > > index 0000000..9e8238f >>> > > --- /dev/null >>> > > +++ b/Documentation/devicetree/bindings/media/fsl-imx-emmaprp.txt >>> > > @@ -0,0 +1,19 @@ >>> > > +* Freescale enhanced Multimedia Accelerator (eMMA) video Pre-processor (PrP) >>> > > + for i.MX. >>> > > + >>> > > +Required properties: >>> > > +- compatible : Shall contain "fsl,imx21-emmaprp". >>> > > +- reg : Offset and length of the register set for the device. >>> > > +- interrupts : Should contain eMMA PrP interrupt number. >>> > > +- clocks : Should contain the ahb and ipg clocks, in the order >>> > > + determined by the clock-names property. >>> > > +- clock-names: Should be "ahb", "ipg". >>> > > + >>> > > +Example: >>> > > + emmaprp: emmaprp@10026400 { >>> > > + compatible = "fsl,imx27-emmaprp", "fsl,imx21-emmaprp"; >> > >> > Is "fsl,imx27-emmaprp" compatible documented somewhere ? > > The overall structure of the eMMA module is slightly different. > As for the part of the PrP, according to the datasheet they are compatible. Then can we please have all the valid compatible strings listed at the 'compatible' property's description above ? I think it is useful to have an indication to which SoC each of them apply in documentation of the binding. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html