Hi Fabio,
I fixed the tabs on MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 line too.
BR,
Vitor
On Mon, Mar 2, 2020 at 6:05 PM Vitor Massaru Iha <vitor@xxxxxxxxxxx> wrote:
>
> Hi Fabio,
>
> Thanks for your review.
>
> On Mon, 2020-03-02 at 14:03 -0300, Fabio Estevam wrote:
> > Hi Vitor,
> >
> > Forgot to say in the previous revision, but the typical Subject
> > pattern is:
> >
> > arm64: dts: imx8mq-phanbell: Add gpio-fan/thermal support
> >
> > On Sun, Mar 1, 2020 at 9:11 PM Vitor Massaru Iha <vitor@xxxxxxxxxxx>
> > wrote:
> >
> > > &A53_0 {
> > > @@ -373,4 +383,58 @@
> > > MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
> > > >;
> > > };
> > > +
> > > + pinctrl_gpio_fan: gpiofanp {
> >
> > Please keep the pinctrl entries in alphabetical order.
> >
> > > + fsl,pins = <
> > > + MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 0x01
> >
> > This pad comes as 0x16 after POR, so please add it as:
> >
> > MX8MQ_IOMUXC_NAND_CLE_GPIO3_IO5 0x16
> >
> > > +&cpu_thermal {
> >
> > Please put it prior to the &i2c1 node in order to keep the
> > alphabetical order.
> >
> > With these changes you can add:
> >
> > Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
>
> I'll send the PATCH v3.
>
> BR,
> Vitor
>
